otp-auth example with rwk #1073
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f481c15:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
moeodeh3
left a comment
moeodeh3
left a comment
There was a problem hiding this comment.
Some small nits. I think it would be awesome to also include a video of the demo and attaching it to the readme (I think we should do this for all our examples!)
In the future, we can also add a partial Auth Proxy + backend folder here - where verification and authentication are handled through the Auth Proxy (with the verificationToken tied to a publicKey), and login occurs via their backend. This approach is more ideal since it mitigates the server takeover risk present in our current with-backend example
examples/otp-auth/README.md
Outdated
| ``` | ||
|
|
||
| This command will run a NextJS app on port 3000. If you navigate to http://localhost:3000 in your browser, you can follow the prompts to start an OTP auth. | ||
| - **User data:** Store and retrieve user data associated with Turnkey sub-organizations. |
There was a problem hiding this comment.
I just left a similar comment on your other pr but to me this doesn't roll off the tongue too well, I think we can remove these sub headers so for example:
- Store and retrieve user data associated with Turnkey sub-organizations
|
|
||
| Once logged in, access a dashboard with two panels: | ||
|
|
||
| **Left:** sign messages and simple demo transactions for both Ethereum and Solana using the **selected** embedded eallet account. Broadcasting uses a standard JSON-RPC client and returns the resulting transaction hash or signature. |
|
|
||
| Once logged in, access a dashboard with two panels: | ||
|
|
||
| **Left:** sign messages and simple demo transactions for both Ethereum and Solana using the **selected** embedded eallet account. Broadcasting uses a standard JSON-RPC client and returns the resulting transaction hash or signature. |
There was a problem hiding this comment.
we don't have eallet accounts yet (coming next quarter 😄 ) - lets also change this to wallet
Summary & Motivation
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.