docs: instructions for TypeScript import #385
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have code like this
This does not recognize the type of
playersincereact-youtubedepend on@types/youtube-player.So I had to install
@types/youtube-playerdev dependency on my project to get type reference for theplayerobject.I think it does not make sense to add
@types/youtube-playerin dependencies ofreact-youtubeso I am adding it as an instruction in README.md.If you or anyone knows better way solving it. let me know, so that I can iterate on this PR.
OR you can make yours and close mine.
Thanks!