tinygo-test fails with undefined symbols

[QuLogic]

With Go 1.18, I am getting the following error when running make tinygo-test:

ld.lld: error: undefined symbol: getpagesize
>>> referenced by os_linux.go:122 (/builddir/build/BUILDROOT/tinygo-0.25.0-1.fc36.x86_64/usr/lib64/tinygo/src/runtime/os_linux.go:122)
>>>               /tmp/tinygo863360999/main.o:(os_test.TestGetpagesize)
error: failed to link /tmp/tinygo863360999/main: exit status 1

With Go 1.19, I additionally get the following error on any test that uses crypto:

ld.lld: error: undefined symbol: crypto/internal/boring/sig.StandardCrypto
>>> referenced by notboring.go:25 (/usr/lib/golang/src/crypto/internal/boring/notboring.go:25)
>>>               /builddir/build/BUILD/tinygo-0.25.0/tinygo.OFH7PV/tinygo/thinlto/llvmcache-51407FBE491F17C7777BEE75E99D1816E029D4F3:(crypto/internal/boring.Unreachable)
error: failed to link /tmp/tinygo3462869915/main: exit status 1

This started with tinygo 0.24.0. It seemed to be related to CGo, so I tried reverting #2774, but that did not help. I also tried force disabling ThinLTO, but that did not help either. So I'm running low on ideas. I am running with external LLVM (14.0.5 against Go 1.19, and 14.0.0 against Go 1.18)

[QuLogic]

Though that being said, 0.23.0 never compiled with Go 1.19, so I can't say if it wouldn't have brought up the same errors. Similarly, the test for getpagesize was only added in 0.24.0, so I can't say it also wouldn't have errored in earlier versions.

So I don't know if this actually regressed from 0.23.0 to 0.24.0 or there are just more tests that show it was already broken.

[QuLogic]

So I backported #2899 to 0.23.0 and it still failed, so this seems to have always been broken and there just wasn't anything that triggered it?

[dkegel-fastly]

Could it be that getpagesize() is no longer available everywhere?
Evidently it is deprecated, see e.g. https://refspecs.linuxbase.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/baselib-getpagesize.html

[aykevl]

@QuLogic I can't seem to reproduce the getpagesize issue on the latest dev branch:

$ tinygo test os
ok      os      0.080s

$ tinygo version
tinygo version 0.26.0-dev linux/amd64 (using go version go1.19 and LLVM version 14.0.6)

Was it the os package that was failing for you?

Also, if you are using the Fedora package, are you sure the musl library is built correctly? It should have a getpagesize symbol.

Could it be that getpagesize() is no longer available everywhere?

We use musl, so if it's missing it's because something is wrong with it.

[QuLogic]

I just tried with 0.26.0 and it is still failing. I don't use any pre-compiled musl Fedora package as tinygo needs it for all the unique architectures it targets that may not be the same as Fedora's. The only difference from the builds here should be that I pull musl from its 1.2.0 release tarball instead of the git commit. Everything else should be the same, but I'll try looking at the musl parts a bit closer.

[aykevl]

I found the issue, working on a fix in #3223. In short, the lib/musl/src/legacy directory needs to be copied like many other musl directories.

[QuLogic]

Yes, I came to the same conclusion. I don't use the Makefile directly, but do copy what is done in the build/release target (I do have some plans to make it reusable for me, but haven't gotten around to it.) And when I run tests, it's against the to-be-installed TINYGOROOT, not the source tree. Since it's found with a glob, tinygo doesn't care that the legacy directory is missing, but as it contains getpagesize, then it fails during linking.

[aykevl]

Since it's found with a glob, tinygo doesn't care that the legacy directory is missing, [...]

Ah of course, that's where I need to insert a check! I have updated #3223 accordingly, thanks for the hint.