nrf: clean up code after CGo improvements #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of a few new features in TinyGo: * Functions and globals in header files are supported. * Static functions are supported. This allows us to remove workarounds specifically used for the lack of support for static functions.
|
This is ready for review. The necessary changes have been merged into TinyGo a long time ago. |
|
Always great to remove code that is no longer needed! Thanks @aykevl now merging. |
Especially when they were workarounds/hacks 😄 Untested, but I suspect it will even make the code slightly more efficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of a few new features in TinyGo:
This allows us to remove workarounds specifically used for the lack of support for static functions.
This is a draft because it depends on tinygo-org/tinygo#2776.