Skip to content

Conversation

@jdecool
Copy link
Collaborator

@jdecool jdecool commented Nov 15, 2021

Fix #22

PHPStan 1.0 has been released.
This PR add compatibility with PHPStan 1.0

@Wirone
Copy link

Wirone commented Nov 15, 2021

Really looking forward into this since we're currently upgrading to PHPStan 1.0 and we need this package too. I was able locally to override Composer requirements with forked version (custom github repository entry in composer.json), test and clean baseline files from errors reported before, but our setup does not work well with this for daily usage (we use Private Packagist and for now we don't have proper flow for delivering auth data for Github API) so I really need to switch constraints to stable release of this package to finish our upgrade process. Please merge it and release new stable tag 🙏

@Wirone
Copy link

Wirone commented Nov 18, 2021

@samizdam @rincler @dmitrivereshchagin @anwinged sorry for pinging but I need to ask is it possible to process this PR? Because I'm stuck with huge merge request (moving to PHPStan 1.0) in our big, monolith app which is hard to maintain in terms of all changes that are made day by day. I really would like to finish it and this package's stable version is required for that.

@samizdam samizdam merged commit f2b10a5 into timeweb:master Nov 18, 2021
@jdecool jdecool deleted the phpstan10-upgrade branch November 18, 2021 21:05
@samizdam
Copy link
Member

Hi!
I release it with https://github.com/timeweb/phpstan-enum/releases/tag/v3.0.0

@Wirone
Copy link

Wirone commented Nov 18, 2021

Thank you very much @samizdam! 🍻

@jdecool
Copy link
Collaborator Author

jdecool commented Nov 19, 2021

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare for PHPStan 1.0

3 participants