Fix build and release process #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename python package dir to "src" to be different from installed package.
Editable install is broken since Setuptools 64 pypa/setuptools#3504 Not supported by scikit-build scikit-build/scikit-build#740 scikit-build/scikit-build#770 scikit-build/scikit-build#939
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of small changes to fix the build and release process.
Editable install is not supported by
scikit-buildwithsetuptools>=64: scikit-build/scikit-build#740, scikit-build/scikit-build#770, scikit-build/scikit-build#939. Because of this, I had to switch to a regular package installation. I also had to rename the package directory (pyfactxx->src) so that there would be no conflict when loading the module.Tests are moved out of package's source directory. So no need to prune them.
New range of supported Python versions: 3.9-3.14.
New default runner for tests is Ubuntu 24.04. Not a rolling
ubuntu-latestso no surprise-failures.windows-latestrunner is set towindows-2025for build jobs for the same reason.ubuntu-20.04is broken and not supported.actions/setup-pythoncan't install Python because of too old Glibc. So, new runner for build jobs isubuntu-22.04. Target changed frommanylinux_2_27_x86_64tomanylinux_2_34_x86_64because of that.CMake now take's Python interpreter from venv (actually, it takes first
pythonfromPATH).Bump minimum
cmakeversion to 3.15. It's OK minimum for Ubuntu 22.04's 3.22 and for current 4.1.2.Minor change to fix build on GCC 13 (Ubuntu 24.04 default) -
#include <cstdint>CodeQL workflow is fixed by version bump and manual build steps for
cpptarget.Codacy workflow is broken: codacy/codacy-analysis-cli#541 All tests are running, but it is impossible to upload the results. Temporary added
continue-on-error: trueto not fail on upload.ilammy/msvc-dev-cmdis broken. Temporary switched to my own fork with fix. Will make PR's to upstream.pypa/gh-action-pypi-publishis switched to Trusted Publisher. Need to createpypienvironment in GH repository. Also, need to setup PyPI in "publishing" settings of owner's account. This step not tested.Summary by Bito
This pull request enhances the build and release process by updating the minimum CMake version, improving Python package handling, and reorganizing the directory structure. It also includes compatibility fixes for newer GCC versions and optimizes CI/CD workflows for better compatibility with Python versions 3.9 to 3.14.