Fix installation inside virtual env #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/prbot describe |
ansobolev
reviewed
Nov 11, 2022
| find_program(PYTHON "python") | ||
| set(PYTHON "python") | ||
|
|
||
| if (PYTHON) |
There was a problem hiding this comment.
Seems to be fine; however, what if a user does not have Python installed on the system? Previously the build system worked in such a way that factpp was able to be built from the root directory even if Python bindings were not needed. However, this PR makes it impossible. If you are OK with that, feel free to merge
|
@knopki there’s some hidden complexity here as you can see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise the Python is taken from
/usr/bin/pythonwhich can lead to some weird import problems