Skip to content

[DNM] Correct transaction interfaces #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[DNM] Correct transaction interfaces #90

wants to merge 3 commits into from

Conversation

sticnarf
Copy link
Collaborator

  1. Remove invalid interfaces such as
  • rollback: an optimistic transaction doesn't need it
  • set_isolation_level: we don't support various isolation levels now (pessimistic transaction, which we will possibly support later, assumes RR but it should not be configurable either)
  1. Use async/await
  2. Fix some documents. Operations like set and delete should not be a Future which needs to be resolved later. They are just buffered in memory.

sticnarf added 3 commits July 31, 2019 13:53
@sticnarf
Use async/await in the transaction APIs
5a0b6fe 
After this commit, the library requires a nightly Rust compiler to build.

The required toolchain version is also updated in README.md and .travis.yml.

Signed-off-by: Yilin Chen <[email protected]>
@sticnarf
Add integration tests for get TS
94f080e 
Signed-off-by: Yilin Chen <[email protected]>
@sticnarf
Remove explicit Futures for transaction
78fa34f 
Signed-off-by: Yilin Chen <[email protected]>
@sticnarf sticnarf changed the title Correct transaction interfaces [DNM] Correct transaction interfaces Jul 31, 2019
@sticnarf sticnarf closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sticnarf