Skip to content

Implement str_width() #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2022
Merged

Implement str_width() #419

merged 1 commit into from
Jan 20, 2022

Conversation

@hadley
Copy link
Member

@hadley hadley commented Jan 18, 2022

And flip str_pad() argument from use_length to use_width so that the default can be positive.

Fixes #380

@hadley
Implement str_width()
88a4a36 
And flip str_pad() argument from use_length to use_width so that the default can be positive.

Fixes #380
@hadley hadley changed the title Implement str_width() Implement str_width() Jan 18, 2022
yutannihilation
yutannihilation approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! use_width is better than my use_length, thanks for the improvement.

@hadley hadley merged commit bd4796d into main Jan 20, 2022
@hadley hadley deleted the width branch January 20, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yutannihilation yutannihilation yutannihilation approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement str_width

3 participants

@hadley @yutannihilation