Skip to content

Implement tidyverse recycling rules #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 26, 2021
Merged

Implement tidyverse recycling rules #376

merged 12 commits into from
Apr 26, 2021

Conversation

@hadley
Copy link
Member

@hadley hadley commented Apr 22, 2021

Will fix #372 when complete.

@hadley hadley changed the title Implement tidyverse recycling rules for str_c() Implement tidyverse recycling rules Apr 25, 2021
@hadley
Copy link
Member Author

hadley commented Apr 25, 2021

Re-thinking str_c() recycling for performance — can maybe just compact()? Need to test all combinations of expected behaviour (with character() and NULL)

@hadley hadley merged commit f1f5eb3 into master Apr 26, 2021
@hadley hadley deleted the recycle branch April 26, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement tidyverse recycling rules

2 participants

@hadley