make detect helpers honor regex "|" operator #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
May 30, 2020
NEWS.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| # stringr (development version) | |||
|
|
|||
| * Update `str_starts()` and `str_ends()` functions so they honor regex "|" operator more intuitively. (@carlganz) | |||
Member
There was a problem hiding this comment.
I’d phrase this more generally - it’s about operator precedence in generally, not just |. Otherwise, looks great.
tests/testthat/test-detect.r
Outdated
| expect_true(str_starts("ab", regex("A", ignore_case = TRUE))) | ||
|
|
||
| # Or operators are respected | ||
| expect_true(str_starts("ab", regex("B|A", ignore_case = TRUE))) |
Member
There was a problem hiding this comment.
Also I don’t think you should using ignore_case as that’s unrelated to this isse
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apropos of this twitter thread here is small PR that updates detect helpers so that they honor regex "|" operator more intuitively. It doesn't break any existing tests, but I didn't run full revdepcheck because I don't want my computer to catch fire.
I'm sure there will be cases where somebody has code that depends on the previous functionality, but I feel pretty strongly that this change makes the API more intuitive.