Added a trim function that I expect to have #177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about naming it |
|
Sure so |
|
Sure... just a suggestion ;) not my pkg |
This is the conventional name in ruby and helps keep some clarity that it does something extra to str_trim
|
Changed to str_squish as the name makes sense |
|
Can you please move to new home (in |
|
Sure thing |
|
By "document with", I meant use Can you please add a bullet to NEWS? It should briefly describe the change (starting with name of the function), and crediting yourself with |
|
Closing this PR - the rebase onto latest master was too much for a Sunday night :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm used to trim functions removing spaces from the middle of strings too. This str_trim_all function therefore does string trim left, center, and right.
PR has new function, man page, and tests.