Skip to content

Adjust version for svglite skip #6176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Adjust version for svglite skip #6176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbf04ba
Adjust version for svglite skip
MichaelChirico Nov 1, 2024
6c8a6a9
Also in test-patterns.R
MichaelChirico Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/testthat/test-patterns.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ test_that("fill_alpha works as expected", {
test_that("geoms can use pattern fills", {

skip_if_not_installed("grid", "4.2.0")
skip_if_not_installed("svglite", "2.1.0")
skip_if_not_installed("svglite", "2.1.2")

# Workaround for vdiffr's lack of pattern support
# See also https://github.com/r-lib/vdiffr/issues/132
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-utilities-checks.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ test_that("check_device finds ragg capabilities", {

test_that("check_device finds svglite capabilities", {
skip_if(
getRversion() < "4.2.0" || !is_installed("svglite", version = "2.1.0"),
getRversion() < "4.2.0" || !is_installed("svglite", version = "2.1.2"),
"Cannot test {svglite} capabilities."
)
tmp <- withr::local_tempfile(fileext = ".svg")
Expand Down
Loading