Simplify legend layout logic #5648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'rc/3.5.0' into isolate_legend_title_logic # Conflicts: # R/guide-custom.R
thomasp85
reviewed
Jan 19, 2024
thomasp85
reviewed
Jan 22, 2024
thomasp85
pushed a commit
that referenced
this pull request
Feb 23, 2024
* extract title logic in `legend_add_title()` * `guide_custom()` uses title logic * simplify legend layout * borrow legend's setup_elements method * make `add_title` a ggproto method * fix messy merge conflict * document `add_title` method * `unique()` --> `unique0()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to the RC aims to make a simplification to
guide_legend().Briefly, this PR adds a
legend_add_title()helper that is used inguide_legend()andguide_custom(). This has two advantages:guide_legend(), as we no longer have to do bookkeeping and adjustments to the key/label positions based on the title.I figured if there was ever a time to simplify the legend layout logic, without having to deal with backward compatibility issues, now is that time.