Skip to content

Conversation

thomasp85
Copy link
Member

Fix #5149

@teunbrand
Copy link
Collaborator

Would you like me to resolve the NEWS.md conflict by harmonising the news? I'm not sure what the implications of that are if we're releasing from the RC branch, i.e. does the future CRAN version get an awkward news section?

@thomasp85
Copy link
Member Author

No, we shouldn't resolve anything at this point. We do that after release before merging in the rc branch.

If we did it now the news in the release would not reflect the actual release

comment = c(ORCID = "0000-0003-4757-117X")),
person("Winston", "Chang", role = "aut",
comment = c(ORCID = "0000-0002-1576-2126")),
person("Lionel", "Henry", role = "aut"),
person("Thomas Lin", "Pedersen", , "thomas.pedersen@rstudio.com", role = c("aut", "cre"),
person("Thomas Lin", "Pedersen", , "thomas.pedersen@posit.co", role = c("aut", "cre"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update the RStudio line at the bottom of the authors to "Posit Software, PBC"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to wait for spring cleaning with this as it was already submitted

@yutannihilation
Copy link
Member

@thomasp85
Thanks for handling the release process. Now that v3.4.1 is released on CRAN, can we merge this?

@thomasp85
Copy link
Member Author

Yes, I'm back from vacation next week so will do it then

@yutannihilation
Copy link
Member

I see, I'll wait for it, thanks.

@thomasp85 thomasp85 requested a review from hadley February 20, 2023 08:27
@thomasp85 thomasp85 merged commit b53b385 into main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release ggplot2 3.4.1
4 participants