Skip to content

Conversation

yutannihilation
Copy link
Member

It seems pak-based workflow is ready to use now. Let's see if this works...

This is now possible with ?ignore and ?ignore-before-r: see some GHA oriented docs here-ish: https://github.com/r-lib/actions/tree/v2/setup-r-dependencies#ignoring-optional-dependencies-that-need-a-newer-r-version
r-lib/pak#290 (comment)

@yutannihilation yutannihilation marked this pull request as ready for review December 14, 2021 14:53
@yutannihilation
Copy link
Member Author

This should be ready to merge now.

- name: Install system dependencies on macOS
if: runner.os == 'macOS'
run: |
# XQuartz is needed by vdiffr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed? I think XQuartz is provided by default now...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, really? Let's try removing this.

@yutannihilation
Copy link
Member Author

Hm, glue now requires R >= 3.4. Since we depend on glue very much, it might be a good time to consider dropping the support for R 3.3.

@thomasp85
Copy link
Member

Just drop it from the test suite - no need to add a hard dependency on 3.4 in the DESCRIPTION...

@yutannihilation
Copy link
Member Author

I see. Considering the users with R 3.3 still can install ggplot2 if they install some older version of glue, just dropping it from the test suite is enough.

@thomasp85
Copy link
Member

Yes, that is my thinking

@yutannihilation
Copy link
Member Author

Failures seems because of this problem. I'll rerun CI when the next version of sf gets released on CRAN.

r-spatial/sf#1899

@yutannihilation yutannihilation mentioned this pull request Mar 2, 2022
@yutannihilation
Copy link
Member Author

Closing in favor of #4747

@yutannihilation yutannihilation deleted the ci/use-pak branch March 2, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants