Skip to content

Give label_bquote() access to calling environment #4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

thomasp85
Copy link
Member

Fix #4141

This PR fixes label_bquote() so it can once again look up functions etc from the calling environment

@thomasp85 thomasp85 added this to the ggplot2 3.3.4 milestone Apr 27, 2021
@thomasp85 thomasp85 requested a review from clauswilke April 27, 2021 11:51
Copy link
Member

@clauswilke clauswilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe add a test for this functionality?

@thomasp85 thomasp85 merged commit 53c1440 into master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rlang::sym not recognized within label_bquote
2 participants