Let geom_sf() remove rows when shape, size or colour is NA

[yutannihilation]

Fix #3483

Currently, GeomSf doesn't have non_missing_aes, but it should be set to avoid errors reported on #3483. I chose shape, size and colour here because

• As GeomSf is a mix of points, lines, and polygons, it should use the combination of non_missing_aes of GeomPoint, GeomLine and GeomPolygon.
  • GeomPoint uses shape, size and colour
  • GeomLine and GeomPolygon don't have their non_missing_aes.
• For lines and polygons, GeomSf removes rows (e.g. the size is NA) that GeomLine and GeomPolygon won't. But, the result is the same; lines and polygons whose sizes are all NA won't be drawn. So, I think it's no problem to remove the whole rows.

devtools::load_all("~/repo/R/ggplot2")
#> Loading ggplot2

pts <- sf::st_sf(
  geometry = sf::st_sfc(sf::st_point(0:1), sf::st_point(1:2)),
  size = c(1, NA),
  shape = c("a", NA),
  colour = c("red", NA)
)

ggplot(pts) + geom_sf(aes(size = size))
#> Warning: Removed 1 rows containing missing values (geom_sf).

ggplot(pts) + geom_sf(aes(shape = shape))
#> Warning: Removed 1 rows containing missing values (geom_sf).

# default colour scale maps a colour even to a NA, so identity scale is needed to see if NA is removed
ggplot(pts) + geom_sf(aes(colour = colour)) + scale_colour_identity()
#> Warning: Removed 1 rows containing missing values (geom_sf).

^{Created on 2019-08-18 by the reprex package (v0.3.0)}

[thomasp85]

LGTM

[yutannihilation]

Thanks!

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/