Deprecate ggdep #3412
Merged
Deprecate ggdep #3412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Jul 8, 2019
R/utilities.r
Outdated
| #' Give a deprecation error, warning, or message, depending on version number. | ||
| #' | ||
| #' This function is deprecated. | ||
| #' Version numbers have the format <major>.<minor>.<subminor>, like 0.9.2. |
There was a problem hiding this comment.
Can you please remove the old text below? Otherwise, looks good.
There was a problem hiding this comment.
I think I have remove the old text
|
Looks good - can you please also add a bullet to NEWS? It should briefly describe the change and end with |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hadley it is good for #3382