redo warnings for overwritten arguments in abline, hline, and vline #3286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…), and geom_vline()
hadley
approved these changes
May 20, 2019
|
Should I add the NEWS bullet here? It doesn't look like there's a set of bullet points started for post-3.2.0.9000 and I think the NEWS.md on my branch is out of date. |
|
Is this intended for 3.2.0? |
|
No, it wasn't. |
|
Ah. Just make a new heading and a bullet then |
hadley
approved these changes
Jun 4, 2019
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to address #3090, and in part overwrites the work from #2950. This PR ensures that:
mappingand one or more ofyintercept/xintercept/slope/interceptare provided.dataand one or more ofyintercept/xintercept/slope/interceptare provided.It is also worth noting that I changed the test for "data is provided" from
missing(data)tois.null(data). I am not sure if there was a good reason for it to have beenmissing(data)in the first place, as something likewould possibly not issue a warning.
I may have gone overboard on the gramatically-correct informative warning message function (
warn_ovewritten_args()), but was trying make all the messages informative without duplicating code.