-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add documentation about labs(tag = )
#2663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe write "The plot tag appears at the top-left by default"?
Thanks! Of course the position is changeable, but "by default" is not added to other labels like |
Rereading it all in context, I'm fine with it as is. One other small issue I noticed, however: In the "Details" section, there's a parenthesis that isn't closed: "You can also set axis and legend labels in the individual scales (using the first argument, the |
Sure, will do later. |
Done! |
@yutannihilation if you wanted to make it even better, I think |
@hadley Thanks, agreed. I've wondered why they are not named args...🙄 Do you mean I should create another PR for this? If so, I'll try tomorrow. But, if you will do, I'm ok. |
A PR would be awesome 😄 (and no rush, since this shouldn't affect any code; although it might be useful to have some tests to verify that) |
Sure! |
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
tag
argument seems not documented in?labs
yet. Sincetag
is intended to be specified bylabs()
, I think this should be described here.