Skip to content

Add documentation about labs(tag = ) #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2018

Conversation

yutannihilation
Copy link
Member

tag argument seems not documented in ?labs yet. Since tag is intended to be specified by labs(), I think this should be described here.

Copy link
Member

@clauswilke clauswilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe write "The plot tag appears at the top-left by default"?

@yutannihilation
Copy link
Member Author

Thanks! Of course the position is changeable, but "by default" is not added to other labels like title, whose positions are also changeable. Does adding "by default" only to tag make sense?

@clauswilke
Copy link
Member

Rereading it all in context, I'm fine with it as is.

One other small issue I noticed, however: In the "Details" section, there's a parenthesis that isn't closed: "You can also set axis and legend labels in the individual scales (using the first argument, the name." Would you mind closing it?

@yutannihilation
Copy link
Member Author

Sure, will do later.

@yutannihilation
Copy link
Member Author

Done!

@hadley hadley merged commit 4299917 into tidyverse:master May 28, 2018
@hadley
Copy link
Member

hadley commented May 28, 2018

@yutannihilation if you wanted to make it even better, I think labs() could use named arguments for title, caption etc. That'll make the function easier to use, and the documentation more clear.

@yutannihilation yutannihilation deleted the doc-label-tag branch May 28, 2018 14:30
@yutannihilation
Copy link
Member Author

@hadley Thanks, agreed. I've wondered why they are not named args...🙄 Do you mean I should create another PR for this? If so, I'll try tomorrow. But, if you will do, I'm ok.

@hadley
Copy link
Member

hadley commented May 28, 2018

A PR would be awesome 😄 (and no rush, since this shouldn't affect any code; although it might be useful to have some tests to verify that)

@yutannihilation
Copy link
Member Author

Sure!

@lock
Copy link

lock bot commented Nov 24, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants