respect show.legend in colorbar #1782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Sep 27, 2016
R/guides-.r
Outdated
|
|
||
| # process layer information | ||
| guides_geom <- function(gdefs, layers, default_mapping) { | ||
| # remove layers with show.legend=FALSE or NA |
Member
There was a problem hiding this comment.
Are you sure this logic is correct? NA means use the default, i.e. show if the aesthetic is used
Member
|
LGTM |
hadley
reviewed
Sep 27, 2016
R/guide-colorbar.r
Outdated
| guide_geom.colorbar <- function(guide, layers, defaul_mapping) { | ||
| # Layers that use this guide | ||
| guide_layers <- plyr::llply(layers, function(layer) { | ||
| matched <- matched_aes(layer, guide, defaul_mapping) |
Member
There was a problem hiding this comment.
defaul_mapping not default_mapping
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1568