previous content from parsnip vignette for predictions #128
+5,707
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is this in relation to tidymodels/parsnip#1293? |
EmilHvitfeldt
approved these changes
Nov 14, 2025
Member
EmilHvitfeldt
left a comment
EmilHvitfeldt
left a comment
There was a problem hiding this comment.
this document is so long!!!
hfrick
approved these changes
Nov 17, 2025
Member
There was a problem hiding this comment.
I like the hierarchy of mode > model type > engine that you've used. I would combine Emil's suggestion of allowing the TOC to go one level deeper with putting the mode in h2, the model type in h3 (both visible in the TOC), and reusing the element from the parsnip article of hiding everything related to one engine underneath the <details> tag. That should make it easy to navigate to the relevant example quickly and a bit more obviously than via the TOC on the right-hand side.
Co-authored-by: Emil Hvitfeldt <[email protected]> Co-authored-by: Hannah Frick <[email protected]>
…e. It disables most of the code from running for now to make it easy to render test
Member
Author
|
@hfrick I think that my changes are all done; please re-review when you get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for suggestions on reordering/restructuring.
Spark is aspirational right now (there are some
eval: falseoptions currently).The TODO list:
<details>for long model prints (<cough>C5<cough>)