Make work with newer versions of xgboost #1307
Open
+254
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I still need to do a little more due diligence to make sure we capture things that we didn't test for. Also right now the GHA doesn't try with the new version of xgboost which seem like a hassle to add. I can confirm that the tests run clean locally. Will need reviewers to verify as well. They all skip on CRAN so it shouldn't be the biggest deal in the world |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface to xgboost was changed with versions past 2.0.0.0. This PR makes parsnip work with both the new and old interfaces as xgboost is trying to update on CRAN as per dmlc/xgboost#11430.
to close #1227