Minor changes #168
Merged
Minor changes #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thygate
reviewed
Apr 10, 2023
Owner
thygate
left a comment
thygate
left a comment
There was a problem hiding this comment.
Please don't use match/case, it was only added in Python 3.10, and a lot of people are still on 3.8
for compatibility with older Python versions < 3.10
thygate
approved these changes
Apr 10, 2023
Collaborator
Author
Good point! Sorry, did not realize this. |
Owner
|
No problem, thanks for cleaning up some of the mess this extension is ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored create_stereoimages, removed duplicated stereo code from depthmap script.
Also made so that the default is to only generate 2 formats - the most common ones.