UI improvements #155
Merged
UI improvements #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thank you, appreciate it! Hopefully nothing broke... |
|
Something broke afterall... Thank you for addressing it! 12d5683 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the UI is somewhat cramped and in some places confusing. This MR greatly simplifies the UI by only showing the relevant options. I hope this will help people who use the script for the first time and struggle to understand how to use the script due to the abundance of options.
Also, there are 5 supported types of generated stereo-images - now they are in a drop-down. I don't think it is likely that anybody would want to generate images for multiple modes (with exactly the same parameters) simultaneously.
This MR also contains some quality-of-code changes.
The main settings panel is no longer defined twice. It is now much easier to change it and to keep track of the changes.
Stereoscope image generation code is moved to a separate file (it is a requested change, also makes it easier to tweak the code). Added some documentation.
@thygate I am happy with the result and did not find any breakage, but the changes are quite major, so it is possible that this requires some improvements.