Skip to content

Conversation

@Adamj1232
Copy link
Contributor

Description

With this all packages within develop will have their versions within package.json prepended with -alpha. This will have two affects.

  1. There will be an alpha version published to NPM that is equivalent with the current release version - this will allow the ReactDemo to properly create a staging env using the latest @next (alpha) versions
  2. The v2-web3-onboard-develop branch will be ready for new development merges. From here when new development is merged to a package, the version will have an incremented -alpha.x at the end
    NOTE - With the first merge of new development into a package the release version will need to be updated as the changes warrant

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

Copy link
Contributor

@taylorjdawson taylorjdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taylorjdawson taylorjdawson self-requested a review May 11, 2022 22:05
Base automatically changed from v2-web3-onboard-develop to v2-web3-onboard May 12, 2022 15:16
@Adamj1232 Adamj1232 changed the base branch from v2-web3-onboard to v2-web3-onboard-develop May 12, 2022 15:27
@Adamj1232 Adamj1232 merged commit 40dcd87 into v2-web3-onboard-develop May 12, 2022
tokensex pushed a commit to tokensex/web3-onboard that referenced this pull request May 30, 2022
@lnbc1QWFyb24 lnbc1QWFyb24 deleted the feature/develop_CI branch June 1, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants