Skip to content

Conversation

@taylorjdawson
Copy link
Contributor

Description

Addresses #918

Checklist

  • The version field in package.json is incremented following semantic versioning
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@taylorjdawson taylorjdawson requested a review from lnbc1QWFyb24 May 8, 2022 21:53
Copy link
Contributor

@lnbc1QWFyb24 lnbc1QWFyb24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@taylorjdawson taylorjdawson changed the base branch from v2-web3-onboard to v2-web3-onboard-develop May 13, 2022 21:29
@Adamj1232
Copy link
Contributor

Adamj1232 commented May 16, 2022

@taylorjdawson you may want to throw an alpha version bump to the package.json of the Core package to test this in staging env...and a version bump for react package(and core package within) so it can use this change

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!!

@taylorjdawson taylorjdawson merged commit 8389414 into v2-web3-onboard-develop May 16, 2022
@taylorjdawson taylorjdawson deleted the feature/locale-function branch May 16, 2022 19:29
tokensex pushed a commit to tokensex/web3-onboard that referenced this pull request May 30, 2022
* [feature]: 2.2.8 - Expose locale function
* Add validation
* Version bumpies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants