Skip to content

Conversation

@wonderbeel
Copy link
Contributor

Description

This PR provides a new package to simplify integration and usage of web3-onboard in vue based applications; we tried to keep the nomenclature as similar as possible to the react one, if you have any doubt or need some changes to accept this PR we will be happ to help you obviously 😃 .

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@lnbc1QWFyb24
Copy link
Contributor

Hey @wonderbeel this is amazing and thank you for adding documentation as well! 🔥
We will review this as soon as possible so we can get this published :)

@wonderbeel
Copy link
Contributor Author

Hey @aaronbarnardsound sorry for the ping, I was wondering if there is some blocking issue and/or if you need something else from me, if you have doubts or need to review something just let me know 😄 .

@lnbc1QWFyb24
Copy link
Contributor

@wonderbeel Sorry for the delay on this, it is queued up for review by @taylorjdawson and he should be getting to it this week.

@taylorjdawson
Copy link
Contributor

@wonderbeel Did you check the box to allow us to commit to your branch? It doesn't look like I am able to

@itsmnthn
Copy link
Contributor

itsmnthn commented May 8, 2022

Looking forward to this feature

@wonderbeel
Copy link
Contributor Author

Ehi @taylorjdawson I think that because of our company restrictions it wasn't possible to do it, I will add you as a mantainer to our fork as a workaround, if someone else from the team needs access let me know.
We will probably update a little the code in the next days BTW because in the last month we used this package internally and discovered some potential performance issues that didn't come out in a simple PoC.

@taylorjdawson
Copy link
Contributor

Okay cool! @wonderbeel can you let me know once you get the code updated so I can re-review?

@wonderbeel
Copy link
Contributor Author

Hey @taylorjdawson , sorry for the ping but we managed to update the vue package, basically the big difference is how we are using rxjs, we noticed that using the observables was causing memory leaks and simply switching to a global subscription + ref to store the state helped the performance tremendously.
If it can help with the testing I also set up a POC, code is available here (the vue package has been replaced with a local file obviously),

@taylorjdawson
Copy link
Contributor

@wonderbeel Awesome thank you for this! 🙌🏾 I will review and see if we can merge today!

@taylorjdawson
Copy link
Contributor

taylorjdawson commented May 13, 2022

@wonderbeel
We are modifying our release workflow, could you do the following:

  • Update target merge branch to v2-web3-onboard-develop
  • Handle conflicts
  • Set the version on the updated packages to include -alpha.1 so 2.0.0-alpha.1

Thank you!

@wonderbeel wonderbeel changed the base branch from v2-web3-onboard to v2-web3-onboard-develop May 14, 2022 08:40
@wonderbeel wonderbeel mentioned this pull request May 14, 2022
4 tasks
@wonderbeel
Copy link
Contributor Author

Closing it in favor of #1002

@wonderbeel wonderbeel closed this May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants