-
Notifications
You must be signed in to change notification settings - Fork 541
Feature: Add vue package #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add vue package #911
Conversation
|
Hey @wonderbeel this is amazing and thank you for adding documentation as well! 🔥 |
|
Hey @aaronbarnardsound sorry for the ping, I was wondering if there is some blocking issue and/or if you need something else from me, if you have doubts or need to review something just let me know 😄 . |
|
@wonderbeel Sorry for the delay on this, it is queued up for review by @taylorjdawson and he should be getting to it this week. |
|
@wonderbeel Did you check the box to allow us to commit to your branch? It doesn't look like I am able to |
|
Looking forward to this feature |
|
Ehi @taylorjdawson I think that because of our company restrictions it wasn't possible to do it, I will add you as a mantainer to our fork as a workaround, if someone else from the team needs access let me know. |
|
Okay cool! @wonderbeel can you let me know once you get the code updated so I can re-review? |
|
Hey @taylorjdawson , sorry for the ping but we managed to update the vue package, basically the big difference is how we are using rxjs, we noticed that using the observables was causing memory leaks and simply switching to a global subscription + ref to store the state helped the performance tremendously. |
|
@wonderbeel Awesome thank you for this! 🙌🏾 I will review and see if we can merge today! |
|
@wonderbeel
Thank you! |
|
Closing it in favor of #1002 |
Description
This PR provides a new package to simplify integration and usage of web3-onboard in vue based applications; we tried to keep the nomenclature as similar as possible to the react one, if you have any doubt or need some changes to accept this PR we will be happ to help you obviously 😃 .
Checklist
package.jsonis incremented following semantic versioning