Skip to content

Conversation

@k-xo
Copy link
Contributor

@k-xo k-xo commented May 15, 2024

Description

Passport is an MPC-based programmable, distributed, and non-custodial key management system, that allows users to generate wallets, scoped to their application, either via user Passkeys, our signer allows you to sign messages and transactions with a Passport Network account.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@socket-security
Copy link

socket-security bot commented May 15, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@adraffy/[email protected] None 0 441 kB adraffy
npm/@emotion/[email protected] environment 0 7.05 kB emotion-release-bot
npm/@metamask/[email protected] None 0 7.65 kB whymarrh
npm/@noble/[email protected] None 0 747 kB paulmillr
npm/@protobufjs/[email protected] None 0 9.05 kB dcode
npm/@types/[email protected] None 0 632 kB types
npm/[email protected] None 0 7.55 kB brianloveswords
npm/[email protected] None 0 164 kB peterolson
npm/[email protected] None 0 351 kB mikemcl
npm/[email protected] None 0 4.38 kB dcousens
npm/[email protected] None 0 156 kB dcposch
npm/[email protected] None 0 5.05 kB linusu
npm/[email protected] None 0 5.67 kB lukeed
npm/[email protected] filesystem, shell 0 62.4 kB abetomo
npm/[email protected] None 0 1.25 MB faddee
npm/[email protected] None 0 315 kB stefanpenner
npm/[email protected] None 0 73.4 kB lpinca
npm/[email protected] None 0 39.7 kB matteo.collina
npm/[email protected] None 0 464 B andreeleuterio
npm/[email protected] network 0 2.79 kB feross
npm/[email protected] filesystem 0 3.01 kB sindresorhus
npm/[email protected] None 0 5.93 kB sindresorhus
npm/[email protected] None 0 2.12 kB kumavis
npm/[email protected] None 0 12.7 kB isaacs
npm/[email protected] None 0 1.41 MB bnjmnt4n
npm/[email protected] None 0 206 kB dougwilson
npm/[email protected] None 0 54.5 kB ljharb
npm/[email protected] None 0 1.66 MB davidlehn
npm/[email protected] environment, filesystem 0 13.2 kB mafintosh
npm/[email protected] None 0 9.22 kB jonschlinkert
npm/[email protected] None 0 97.2 kB ljharb
npm/[email protected] None 0 2.74 kB coderpuppy
npm/[email protected] None 0 54.3 kB goto-bus-stop
npm/[email protected] None 0 15.3 kB cwmma
npm/[email protected] None 0 117 kB kazuhikoarase
npm/[email protected] None 0 42.3 kB chalker
npm/[email protected] None 0 10.6 MB conduitry
npm/[email protected] None 0 19.1 kB dcousens
npm/[email protected] None 0 116 kB ctavan
npm/[email protected] None 0 9.03 kB chrisdickinson
npm/[email protected] None 0 198 kB addons-robot
npm/[email protected] None 0 6.46 kB raynos

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@jridgewell/[email protected], npm/@unstoppabledomains/[email protected], npm/@web3-onboard/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@socket-security
Copy link

socket-security bot commented May 15, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@@ -0,0 +1,301 @@
import type { WalletInit } from '@web3-onboard/common'
import type { AuthenticatedHeaders } from '@0xpass/passport/dist/types'
import type { PassportOptions } from 'types'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import type { PassportOptions } from 'types'
import type { PassportOptions } from './types'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Adamj1232
Copy link
Contributor

@k-xo looking good, just a few more comments/questions.
Are there any build env configurations that would need to be considered or added to our build env docs? ex. https://github.com/blocknative/web3-onboard/blob/76a38237a2d5e71cce73ecbf979cf249a532488d/docs/src/routes/docs/%5B...3%5Dmodules/%5B...1%5Dcore/%2Bpage.md?plain=1#L1460

@k-xo
Copy link
Contributor Author

k-xo commented May 17, 2024

@k-xo looking good, just a few more comments/questions. Are there any build env configurations that would need to be considered or added to our build env docs? ex.

https://github.com/blocknative/web3-onboard/blob/76a38237a2d5e71cce73ecbf979cf249a532488d/docs/src/routes/docs/%5B...3%5Dmodules/%5B...1%5Dcore/%2Bpage.md?plain=1#L1460

Requests comments / changes made :). For the build configuration I don't think we need to add any build env docs, we use the web crypto api for our needs so far, which I believe should work for most / all browsers.

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for submitting a PR!

@Adamj1232 Adamj1232 merged commit 13653b9 into thirdweb-dev:develop May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants