add echooowallet #2187
add echooowallet #2187
Conversation
There was a problem hiding this comment.
Hi @rqzrqh thank you for the PR to support echooo wallet.
As this is an injected wallet we do not support adding a new module specific for the injected wallet as module upkeep is extensive and all actions of adding a whole new module for an injected wallet can be done through the injected-module package.
If you can remove the echoo package, echoo page within the docs and CI pipeline changes we should be gtg.
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
Is there any documentation that can help me complete the import of wallet plugin to blocknative? @Adamj1232 |
|
@lianshao123 Steps to get this PR ready to go would be:
Here is some documentation around adding a wallet and contributing to the project - https://onboard.blocknative.com/docs/overview/contribution-guide#how-can-i-add-a-new-wallet-%F0%9F%92%B3 |
|
One version has been submitted, please review it @Adamj1232 |
3 participants
Description
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (injected)
Tests with demo app (SDK)