Refactor: import @walletconnect/ethereum-provider dynamically #2033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Adamj1232 please let me know if I need to adjust anything. Cheers |
Adamj1232
reviewed
Jan 2, 2024
|
Thanks @katspaugh! Ill give er a test first thing tomorrow! Cheers |
|
@katspaugh after digging in there were a few other updates for the WC module. I have added them in this PR - #2036 |
|
Cool, thank you! I'll close this then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
@walletconnect/ethereum-providerpackage is a big dependency, and it was imported twice: statically and dynamically.I've moved the static import to the dynamic one.
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errors