Skip to content

Conversation

@jjasonlan
Copy link
Contributor

@jjasonlan jjasonlan commented Dec 6, 2023

Description

Fixes a bug where capsule wallet would not disconnect successfully.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@vr2amesh
Copy link
Contributor

vr2amesh commented Dec 6, 2023

Looks great to me!

{
"name": "@web3-onboard/capsule",
"version": "2.0.0",
"version": "2.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "2.0.1",
"version": "2.0.1-alpha.1",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@vr2amesh
Copy link
Contributor

vr2amesh commented Dec 7, 2023

NOTE:

I am combining the Fragment fix in with this PR as it is a critical change

@socket-security
Copy link

socket-security bot commented Dec 7, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Adamj1232 Adamj1232 merged commit 69adf61 into thirdweb-dev:develop Dec 7, 2023
@Adamj1232 Adamj1232 changed the title logout capsule wallet on disconnect 2.0.1-alpha.1 : Capsule - logout on disconnect Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants