Skip to content

Conversation

@cole1-yang
Copy link
Contributor

@cole1-yang cole1-yang commented Sep 20, 2023

Hi Blocknative team,

This PR adds bitget wallet to the list of supported wallets and upgrades bitkeep wallet to the bitget wallet to make it easier for our users to connect to web3-onboard dapps.

Please let me know if anything needs to be added or changed to satisfy your requirements.

Cheers,
bitget wallet team

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@socket-security
Copy link

socket-security bot commented Sep 26, 2023

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@bitget-wallet/web3-sdk 0.0.6 None +18 34.1 MB phoenix-bitget
@solana/web3.js 1.78.0...1.74.0 None +8/-2 11.5 MB _chido

@Adamj1232
Copy link
Contributor

@kisenyang I have updated code, version and added CI
I am seeing an error when running yarn check-all when building that looks to be an issue with the type files in each new module. Can you please resolve this issue?
Once completed I can add to our docs site and merge for alpha testing!
Thanks again!

@Adamj1232
Copy link
Contributor

@kisenyang this doesnt seem to have been tested as it is not working with the internal testing demo.
There were steps in the description that were deleted along with check boxes that need to be confirmed for both wallet modules.
Use yarn dev and navigate to http://localhost:8080/ to test modules work for both packages please.
Currently the icon doesn't even load.

@Adamj1232 Adamj1232 merged commit 24c825d into thirdweb-dev:develop Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants