Skip to content

Conversation

@quybeans
Copy link
Contributor

Description

This PR adds support to Ronin Wallet, a crypto wallet operates on Ronin blockchain.

Some important note for reviewer:

  • Ronin Wallet only supports Ronin chain (chainId: 2020) and Saigon Testnet (chainId: 2021). Therefore we don't implement rpc wallet_switchEthereumChain or wallet_addEthereumChain
  • Ronin Wallet implements the allowlist feature, which only allow certain sites to interact on Ronin mainnet only. We are looking to disable this feature in the future to allow any sites to connect.
  • If you are testing this with demo, make sure to switch Ronin Wallet to Saigon testnet to disbale the allowlist feature.

I tried testing this with packages/demo app, let me know if anything is not working. Thank you for your review 🙌.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@quybeans
Copy link
Contributor Author

@Adamj1232 thanks for the info! I've restored core package to original. This PR implements support for Ronin Wallet only.

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thanks for contributing!

@Adamj1232 Adamj1232 merged commit 04a0249 into thirdweb-dev:develop Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants