Skip to content

Conversation

@rony-arnac
Copy link
Contributor

@rony-arnac rony-arnac commented Jul 9, 2023

Description

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@Adamj1232
Copy link
Contributor

Thanks for the PR @rony-arnac !
Can you ensure all of the necessary testing steps are completed within the PR description for injected wallets using the internal demo app? Just run yarn && yarn dev from the root of the project
Also, you have the ability to pass an external download link if wanted - see the MetaMask implementation for example

@Adamj1232
Copy link
Contributor

@rony-arnac code looks good! Wanted to check on these points again for testing prior to merge:

  • Can you ensure all of the necessary testing steps are completed within the PR description for injected wallets using the internal demo app? Just run yarn && yarn dev from the root of the project
  • Also, you have the ability to pass an external download link if wanted - see the MetaMask implementation for example.

There are checkboxes in the PR description to check after these have been fully tested.

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @rony-arnac !

@Adamj1232 Adamj1232 merged commit ddfb620 into thirdweb-dev:develop Jul 14, 2023
Adamj1232 added a commit that referenced this pull request Jul 20, 2023
* Fix file imports for validation within WC to handle ESM envs (#1833)

* Cede store new implementation (#1804)

* feat: cede store new implementation

* fix: version fix and changing mocked chain to the existing one

* feat: cede-store-provider-upgrade-1.0.3

* fix: remove yarn.lock files

* Format and yarn it

* Revert deletion of yarn.lock from demo

---------

Co-authored-by: Mathieu <[email protected]>
Co-authored-by: Nikita TEREKHOV <[email protected]>
Co-authored-by: Adam Carpenter <[email protected]>

* feat: add Fordefi wallet (#1820)

* feat: add Fordefi wallet

* fix: remove comma

* Update packages/injected/src/types.ts

---------

Co-authored-by: Adam Carpenter <[email protected]>

* Update: Return bn_protect protect btn to update the user's RPC (#1841)

* Add back in btn protect btn that was accidentally removed during the AC redesign

* Bump core version in docs

* Cleanup onboard service in docs

* Update frame icon

* Bump frame version

* Update global version

* Remove alpha flags

---------

Co-authored-by: clementjuventin <[email protected]>
Co-authored-by: Mathieu <[email protected]>
Co-authored-by: Nikita TEREKHOV <[email protected]>
Co-authored-by: Rony Fragin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants