Fix: Account Center Minimized chain icon display standardization #1719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
leightkt
reviewed
May 15, 2023
| class="chain-icon flex justify-center items-center" | ||
| style={`background-color: ${ | ||
| validAppChain | ||
| <div class="chain-icon-container"> |
Contributor
There was a problem hiding this comment.
Does the same thing need to happen in Micro.svelte?
Contributor
Author
There was a problem hiding this comment.
@leightkt good question! Luckily micro is already using the WalletAppBadge component that handles the chain icons properly
leightkt
approved these changes
May 15, 2023
This was referenced May 18, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Standardize the visualization of the chain icon within Account Center minimized and bring in line with Account Center Maximized. This handles icons imported outside of svg strings.
Handles discord issue shown here: https://discord.com/channels/542403978693050389/1050488289775321148/1107715492006862928
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errors