feat: cede store new implementation #1709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Mario2206
force-pushed
the
cede-store-new-implementation
branch
2 times, most recently
from
8527abd to
bb74050
Compare
Mario2206
force-pushed
the
cede-store-new-implementation
branch
from
bb74050 to
3f9d47f
Compare
Adamj1232
reviewed
May 12, 2023
Adamj1232
reviewed
May 12, 2023
Contributor
Adamj1232
left a comment
Adamj1232
left a comment
There was a problem hiding this comment.
Looks good, small change to version if bumping the minor although I think this could be a patch update
0xnikter
reviewed
May 12, 2023
| return [activeVault?.name || accounts[0].name] as string[] | ||
| }, | ||
| eth_chainId: () => Promise.resolve('0x0'), // cede.store doesn't support chains, but we have to provide a value to complete the connection | ||
| eth_chainId: () => Promise.resolve('0x1'), // cede.store doesn't support chains, but we have to provide a value to complete the connection |
Contributor
There was a problem hiding this comment.
Changed to the existing chainId to fix this error:
Adamj1232
approved these changes
May 15, 2023
This was referenced May 18, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return vault name when the connection process is done.
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (injected)
Tests with demo app (SDK)