Skip to content

Conversation

@laurencedelisle
Copy link
Contributor

Description

Update FeaturesSection to include the core package size minified to show the reduced package size to developers.

Screen Shot 2023-05-08 at 9 15 53 AM

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

When not referencing the code, we should always use Web3 Onboard. When referencing code, we use web3-onboard.
Update FeaturesSection to include the core package size minified.
@vercel
Copy link

vercel bot commented May 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-onboard-docs ❌ Failed (Inspect) May 9, 2023 2:47pm

@Adamj1232 Adamj1232 changed the base branch from docs-main to develop May 8, 2023 16:19
@Adamj1232
Copy link
Contributor

@laurencedelisle to avoid merge conflicts you can create your feature/update branch from the develop branch and then merge into develop which will then be merged into docs branch that deploys the docs site

@Adamj1232 Adamj1232 merged commit 01d8044 into develop May 9, 2023
@Adamj1232 Adamj1232 deleted the minimal-dependancies-content-change branch May 9, 2023 15:21
Adamj1232 added a commit that referenced this pull request May 9, 2023
* Release 2.21.3 (develop) (#1656)

* Bump docs packages

* Update package versions for release

* Remove optional chain in trezor

* add safeheron to injected package readme

* add wallet as value to translate function in more areas of connect

* package updates

* add images

* text update

* Update packages/react/package.json

Co-authored-by: Adam Carpenter <[email protected]>

* Update packages/vue/package.json

Co-authored-by: Adam Carpenter <[email protected]>

* add screenshots to top level assets folder

* update react pkg

* fix merge conflict in react pkg

* fix vue pkg

---------

Co-authored-by: Kat Leight <[email protected]>
Co-authored-by: Kat Leight <[email protected]>

* Update react hooks docs re usage of apiKey (#1668)

* update supported networks svg

* fix indentation

* FEATURE: Add cede.store wallet package (#1667)

* FEATURE: Add cede.store wallet package

* Formatting and add to docs site

* DOCS: Add cede.store detailed documentation with an example flow

* Update formatting - looks good!

---------

Co-authored-by: Adam Carpenter <[email protected]>

* Release 2.21.4 (develop) (#1671)

* Update cede and WC docs (#1681)

* add webpack-dev-server to dependencies (#1680)

* Feat: Secondary Token Balances (#1679)

* RPC working from hackathon

* Working as expected for setting balances in state, no rendering yet

* Display but need to be abstracted and cleaned

* Added layout and styling for secondary tokens along with rework of maximized account center layout, still need docs updates for secondary tokens

* Fix compiler err

* Add docks for secondaryTokens and screenshots to readme and docs of AC

* Fix versioning of common

* Bump common

* Bump all versions required

* Prettify common validation

* Fix: Walletconnet - wallet switching chains and handling int and hex chainIds (#1682)

* Wallet switching chains now working properly and setting required chains to the config chains in w3o

* Fix web3auth ci build

* Update HeroSection.svelte (#1685)

update title from web3-onboard to Web3 Onboard. When not referencing code we should stick to no dash

* Update the core version within vue and react projects (#1686)

* Playwright (#1609)

* change scripts loaded for dev server, fix walletConnect, update webpack config, fix accounts error on no wallet connection (#1689)

* Update FeaturesSection.svelte (#1684)

* Update title Web3-Onboard to Web3 Onboard

When not referencing the code, we should always use Web3 Onboard. When referencing code, we use web3-onboard.

* Update FeaturesSection.svelte

Update FeaturesSection to include the core package size minified.

* Update docs/src/lib/components/HeroSection.svelte

---------

Co-authored-by: Adam Carpenter <[email protected]>

* Fix: Secondary Token Symbol fetch and docs (#1690)

* Fixing

* Update SecondaryToken type

* Add max of 5 tokens to secondaryTokens, add error handling in html, add docs update

* Bump all package versions

* Revert node version changes for web3auth

* Remove cede from wallets group

* Remove merge conflict in yarn.lock

* Update packages/cede-store/README.md

* Fix image path in docs

* Update Account Center example with a better shot

* Spelling & web3 onboard cohesion update (#1694)

updating some spelling and web3 onboard referneces

* Update account center shot to show multiple wallets connected

* Update account center shot to show multiple wallets connected

---------

Co-authored-by: Kat Leight <[email protected]>
Co-authored-by: Kat Leight <[email protected]>
Co-authored-by: Gustavo Esquinca <[email protected]>
Co-authored-by: Nikita TEREKHOV <[email protected]>
Co-authored-by: Laurence <[email protected]>
goosewobbler pushed a commit to goosewobbler/web3-onboard that referenced this pull request May 10, 2023
* Update title Web3-Onboard to Web3 Onboard

When not referencing the code, we should always use Web3 Onboard. When referencing code, we use web3-onboard.

* Update FeaturesSection.svelte

Update FeaturesSection to include the core package size minified.

* Update docs/src/lib/components/HeroSection.svelte

---------

Co-authored-by: Adam Carpenter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants