Skip to content

Conversation

@Adamj1232
Copy link
Contributor

Description

Add peer dep required to run package outside of walletconnect eco: "@web3modal/standalone":"^2.2.2"

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

@Adamj1232 Adamj1232 requested a review from leightkt April 3, 2023 17:07
@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-onboard-docs ❌ Failed (Inspect) Apr 3, 2023 5:08pm

Copy link
Contributor

@leightkt leightkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Adamj1232 Adamj1232 merged commit 5dbc250 into develop Apr 3, 2023
@Adamj1232 Adamj1232 deleted the wc/add_peerDep branch April 3, 2023 17:12
Adamj1232 added a commit that referenced this pull request Apr 4, 2023
* Yarn docs

* update favicon on docs site (#1611)

* Update Notify section on the docs site and within readme (#1612)

* Update notify docs on docs site and within readme

* Update notify api docs

* Add screenshots

* Update signup link

* Remove export from types in docs

* Update Docs Favicon to Url (#1618)

* Fix broken link in docs (#1616)

* Add Kat to GH issue and notion card generation + Fix doc prop name for connect property (#1593)

* Yarn the docs

* Fix doc prop name for connect property

* Add new notion Flag

* Add Kat to gh issue notion cards

* Update Broken Links on Docs Pages (#1619)

* Update WalletConnect `eth_RequestAccounts` flow along with update WC deps and add new optional params (#1622)

* Update WC packages

* Add logs for testing

* Refactor eth_requestAccounts flow

* Why Don't I See My Wallet Link (#1617)

* Add peer dep required to run package outside of walletconnect eco (#1623)

* Update versions for release

* Bump versions

---------

Co-authored-by: Kat Leight <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants