Skip to content

Conversation

@Adamj1232
Copy link
Contributor

@Adamj1232 Adamj1232 commented Mar 23, 2023

Description

Add Sepolia testnet to native support(chain icon and background color - both point to the Eth mainnet values)

Closes #1598

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

@vercel
Copy link

vercel bot commented Mar 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
web3-onboard-docs ❌ Failed (Inspect) Mar 23, 2023 at 10:23PM (UTC)

Copy link
Contributor

@lnbc1QWFyb24 lnbc1QWFyb24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a sneaky log in there to remove.

@Adamj1232 Adamj1232 merged commit ef3970c into develop Mar 23, 2023
@Adamj1232 Adamj1232 deleted the update/add_sepolia_testnet branch March 23, 2023 22:24
@lewis-kori
Copy link

@Adamj1232 Thank you so much for the amazing work.
Just one more thing I noticed.
The notification callback in the notify package doesn't receive events for the Sepolia test net. We use this to record payments, analytics among other things

I wasn't sure where to reach out with this.

@Adamj1232
Copy link
Contributor Author

@lewis-kori We are very happy that you are enjoying web3-onboard!
We currently don't have transaction notifications running on Sepolia but it is on our roadmap and will be prepped as Goerli wind-down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add Sepolia test net to the supported chains

5 participants