-
Notifications
You must be signed in to change notification settings - Fork 541
Feature - New Font Usage (Inter) and Dynamic Font Handling #1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lnbc1QWFyb24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a console log to be removed and a question around the check if a font has been defined.
Also where is the dynamic loading occurring? It all looks like it is imported regardless of configuration from what I can tell?
Co-authored-by: Aaron <[email protected]>
|
Refactored and moved to the CDN approach as recommended. |
lnbc1QWFyb24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
leightkt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in the demo with useWebFont: true and passing custom font via --w3o-font-family
Description
Notion card with stats and pictures
Option to define a font through either the new theme property
--w3o-font-familyor the legacy css font var--onboard-font-family-normalOr set
useWebFontto true and use the default fallbacksans-seriffont by settingType changes:
Add
'--w3o-font-family'Themeprop:Add
useWebFontboolean prop to init options:Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errors