Add Infinity Wallet Connector #1540

teemoshrooms · 2023-02-17T19:57:02Z

Description

Added Infinity Web3 Browser connector and added as an option in the web3 onboard modal.

Checklist

The version field in package.json of the package you have made changes in is incremented following semantic versioning and using alpha release tagging
The box that allows repo maintainers to update this PR is checked
I tested locally to make sure this feature/fix works
I have run yarn file-check, yarn type-check & yarn build to confirm there are not any associated errors
This PR passes the Circle CI checks

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (SDK)

vercel · 2023-02-17T19:57:06Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
web3-onboard-docs	❌ Failed (Inspect)			Feb 27, 2023 at 4:21PM (UTC)

Adamj1232 · 2023-02-21T19:23:08Z

@arons1 thanks for the PR! We will take a look at this in the next couple days

packages/infinity-wallet/package.json

packages/infinity-wallet/src/index.ts

packages/infinity-wallet/yarn.lock

Adamj1232 · 2023-02-22T17:32:00Z

packages/injected/src/wallets.ts

+  checkProviderIdentity: ({ provider }) =>
+    !!provider && !!provider[ProviderIdentityFlag.InfinityWallet],
+  getIcon: async () => (await import('./icons/infinitywallet.js')).default,
+  getInterface: getInjectedInterface(ProviderIdentityFlag.InfinityWallet),


Has this been tested through the injected package without the sdk added within the local demo project?
I saw it was removed from the PR checklist.
Sometimes getInjectedInterface is not the correct method and createEIP1193Provider is better suited depending on the wallet

Adamj1232

Looking good! Thank you again for the PR!
A few changes requested noted in the comments.
You will also want to add Infinity to the docs site that is part of this repo.
Checkout this PR for an example of adding to the docs site.
You will need to use yarn link to ensure the module works within the docs site.

packages/demo/package.json

Adamj1232

Thanks for the PR!

* update root path (#1543) * Add XDEFI module and injected to docs site (#1544) * Add xdefi to docs * Add xdefi module to docs * Add xdefi package to docs onboard * Add to injected wallets list * Feature: "I don't have a wallet" flow + Progress-bar fixup (#1535) * Link working and styled * Progress bar work * Cleanup progressbar code * Remove single quote breaking view * Revert TP testing code * add transaction preview graphic * add transaction preview install code snippet * move md code snippets - update imports * add transaction preview section to landing page * update theming code snippet * update hero section install code * update account center graphic * update hero w3o graphic * update account center svg * Update README.md (#1547) Yeah maybe this needs more thorough changes throughout the docs but I was caught up on this for a minute, and this will help * move transaction preview section to top * update link url * Added XDEFI to readme * Add theming docs, refine core init options, api actions and code chunks (#1548) * Add theming docs, still needs refinement * More docs * Add theming video * More docs * Update layout and add copy to some code chunks * Add dividers for better visibility between options and copy to code blocks where useful * Reorder Theming docs layout * Add note about ethers v6 usage * edit theming page - add css variables table - edit theme descriptions - re-org existing content * Update docs/src/lib/components/examples/connect-wallet/ReactConnectWallet.md * Update theming tool to default to custom --------- Co-authored-by: Gustavo Esquinca <[email protected]> * Update docs/src/lib/components/code-snippet/theming-code.md Co-authored-by: Adam Carpenter <[email protected]> * Bump versions for release * Add Infinity Wallet Connector (#1540) * Add Infinity Wallet Connector * Update packages/infinity-wallet/package.json * Update packages/infinity-wallet/src/index.ts * Remove yarn lock from infin package * Update packages/demo/package.json * Add inifinity to docs * Reorder wallets * Update docs title * Bump innjected package version --------- Co-authored-by: Adam Carpenter <[email protected]> * [walletconnect-2.3.0-alpha.3] - Feat: Walletconnect URI handler + bump wc package version (#1552) * accept handleUri prop * Update docs * Rename wc prop to handleUri * Bump wc pakcage version for walletconnect/ethereum-provider * merge in dev * Revert unintended change * Update prop in docs * Cleanup semicolon * Yarn it! * Bump undici from 5.10.0 to 5.19.1 in /examples/with-sveltekit (#1532) Bumps [undici](https://github.com/nodejs/undici) from 5.10.0 to 5.19.1. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.10.0...v5.19.1) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam Carpenter <[email protected]> * Update fortmatic docs --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Taylor Dawson <[email protected]> Co-authored-by: Gustavo Esquinca <[email protected]> Co-authored-by: Brent <[email protected]> Co-authored-by: mhchaudhry3 <[email protected]> Co-authored-by: mhchaudhry3 <[email protected]> Co-authored-by: Aaron <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Adamj1232 · 2023-03-06T17:57:38Z

@arons1 we are seeing an issue with the Infinity Wallet when used within svelte-kit and have had to temporarily remove it from our docs site. Do you have insight into build configurations for the connector?
Issue: #1564

Add Infinity Wallet Connector

b49a43c

vercel bot had a problem deploying to Preview February 17, 2023 19:58 Failure

Adamj1232 reviewed Feb 22, 2023

View reviewed changes

packages/infinity-wallet/package.json Outdated Show resolved Hide resolved

Adamj1232 reviewed Feb 22, 2023

View reviewed changes

packages/infinity-wallet/src/index.ts Outdated Show resolved Hide resolved

Adamj1232 reviewed Feb 22, 2023

View reviewed changes

packages/infinity-wallet/yarn.lock Outdated Show resolved Hide resolved

Adamj1232 reviewed Feb 22, 2023

View reviewed changes

Adamj1232 suggested changes Feb 22, 2023

View reviewed changes

Adamj1232 added 4 commits February 24, 2023 15:05

Update packages/infinity-wallet/package.json

23bc15f

Update packages/infinity-wallet/src/index.ts

fea879a

Remove yarn lock from infin package

922bfa1

Merge remote-tracking branch 'upstream/develop' into develop

1378d34

Adamj1232 reviewed Feb 24, 2023

View reviewed changes

packages/demo/package.json Outdated Show resolved Hide resolved

Update packages/demo/package.json

9181989

vercel bot had a problem deploying to Preview February 24, 2023 22:12 Failure

Adamj1232 added 2 commits February 24, 2023 15:21

Add inifinity to docs

740e06b

Reorder wallets

f10e857

vercel bot had a problem deploying to Preview February 24, 2023 22:22 Failure

Update docs title

90bc0e0

vercel bot had a problem deploying to Preview February 27, 2023 16:19 Failure

Bump innjected package version

704c72f

vercel bot had a problem deploying to Preview February 27, 2023 16:21 Failure

Adamj1232 approved these changes Feb 27, 2023

View reviewed changes

Adamj1232 merged commit df817dc into thirdweb-dev:develop Feb 27, 2023

This was referenced Feb 27, 2023

Release 2.20.3 (develop) #1553

Merged

Release 2.20.3 #1554

Merged

Release 2.20.3 (docs) #1555

Merged

Adamj1232 mentioned this pull request Feb 28, 2023

Release 2.20.3 #1557

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Infinity Wallet Connector #1540

Add Infinity Wallet Connector #1540

Uh oh!

teemoshrooms commented Feb 17, 2023 •

edited

Loading

Uh oh!

vercel bot commented Feb 17, 2023 •

edited

Loading

Uh oh!

Adamj1232 commented Feb 21, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Adamj1232 Feb 22, 2023

Uh oh!

Adamj1232 left a comment

Uh oh!

Uh oh!

Adamj1232 left a comment

Uh oh!

Adamj1232 commented Mar 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add Infinity Wallet Connector #1540

Add Infinity Wallet Connector #1540

Uh oh!

Conversation

teemoshrooms commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

If this PR includes changes to add an injected wallet or SDK wallet module:

Tests with demo app (SDK)

Uh oh!

vercel bot commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Adamj1232 commented Feb 21, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Adamj1232 Feb 22, 2023

Choose a reason for hiding this comment

Uh oh!

Adamj1232 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Adamj1232 left a comment

Choose a reason for hiding this comment

Uh oh!

Adamj1232 commented Mar 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

teemoshrooms commented Feb 17, 2023 •

edited

Loading

vercel bot commented Feb 17, 2023 •

edited

Loading