Update Transaction Preview Gas Used view - Add TP example to the Docs #1527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamj1232
requested review from
gesquinca,
leightkt,
lnbc1QWFyb24 and
taylorjdawson
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leightkt
approved these changes
Feb 15, 2023
Contributor
leightkt
left a comment
leightkt
left a comment
There was a problem hiding this comment.
I wasn't sure how to test the sidebar backward compatibility- but everything else is looking good.
Contributor
Author
Thanks @leightkt ! |
gesquinca
reviewed
Feb 15, 2023
Contributor
There was a problem hiding this comment.
Some small suggestions. @Adamj1232 let me know what you think!
gesquinca
approved these changes
Feb 15, 2023
This was referenced Feb 15, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To test:
yarn && yarn devcd docs/from the root of the projectyarn link @web3-onboard/transaction-preview && yarn && yarn devhttp://localhost:3000/docs/modules/transaction-preview#usage-with-web3-onboard-core-packageThis PR includes a couple bug fixes to the core package for backwards compatibility including:
sidebar.headingto the connect viewbackground-color->backgroundUpdating the Transaction Preview gas calculation, view and functionality to get standalone working properly(required for docs usage outside of W3O integration)
Adding a RP example button to the docs:
Checklist
package.jsonof the package you have made changes in is incremented following semantic versioning and using alpha release taggingyarn file-check,yarn type-check&yarn buildto confirm there are not any associated errorsIf this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/