Skip to content

Conversation

@kabaluyot
Copy link
Contributor

@kabaluyot kabaluyot commented Jan 30, 2023

Description

Support for Crypto.com DeFi Wallet provider

Checklist

  • The version field in package.json of the package you have made changes in is incremented following semantic versioning and using alpha release tagging
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn file-check, yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Without DeFi Wallet provider

Screen Shot 2023-01-30 at 12 03 22 PM

With DeFi Wallet provider

Screen Shot 2023-01-30 at 12 04 36 PM

Connected DeFi Wallet provider

Screen Shot 2023-01-30 at 12 12 21 PM

@vercel
Copy link

vercel bot commented Jan 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
web3-onboard-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 30, 2023 at 4:30PM (UTC)

@Adamj1232
Copy link
Contributor

@kabaluyot thank you for the PR! I will give it a check and test it out

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kabaluyot good work! Thank your for submitting a PR and contributing!!

@Adamj1232 Adamj1232 merged commit 76d89a5 into thirdweb-dev:v2-web3-onboard-develop Jan 30, 2023
This was referenced Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants