Skip to content

Add gas unsubscribe on destroy #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2022
Merged

Add gas unsubscribe on destroy #1360

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0923b49
Unsub from gas sub
Adamj1232 Nov 13, 2022
b84f2e7
rename
Adamj1232 Nov 13, 2022
b03d84c
Null check
Adamj1232 Nov 13, 2022
4fbcc14
prettier
Adamj1232 Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions docs/src/lib/components/gas/Gas.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import anime from 'animejs'
import GasCard from './GasCard.svelte'
import gasModule from '@web3-onboard/gas'
import { onMount } from 'svelte'
import { onDestroy, onMount } from 'svelte'
import { ethers } from 'ethers'
import type { GasPrice, RPCGasPrice, GasData } from './types'

Expand All @@ -19,14 +19,15 @@
})
}
let ethMainnetGasBlockPrices
let gasSub
let rpcGasData: RPCGasPrice
onMount(() => {
ethMainnetGasBlockPrices = gasModule.stream({
chains: ['0x1'],
apiKey: 'da1b962d-314d-4903-bfe1-426821d14a35',
endpoint: 'blockPrices'
})
ethMainnetGasBlockPrices.subscribe(() => {
gasSub = ethMainnetGasBlockPrices.subscribe(() => {
async function getEtherGasFromRPC() {
const INFURA_ID = '8b60d52405694345a99bcb82e722e0af'
const infuraRPC = `https://mainnet.infura.io/v3/${INFURA_ID}`
Expand Down Expand Up @@ -62,6 +63,10 @@
estimatedTransactionCount: null,
seconds: null
}

onDestroy(() => {
gasSub && gasSub.unsubscribe()
})
</script>

<div class="Gas px-6 p-4">
Expand Down