Skip to content

Update [...2]onboard.js-migration-guide.md #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 25, 2022
Merged

Update [...2]onboard.js-migration-guide.md #1320

merged 9 commits into from
Oct 25, 2022

Conversation

@laurencedelisle
Copy link
Contributor

@laurencedelisle laurencedelisle commented Oct 13, 2022 •
edited by Adamj1232
Loading

Description

Added in missing links and updated some punctuation/grammar for docs.

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

@laurencedelisle
Update [...2]onboard.js-migration-guide.md
74b278e 
updated links, punctuation and grammar.
@vercel
Copy link

vercel bot commented Oct 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
web3-onboard-docs ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 7:29PM (UTC)

@laurencedelisle laurencedelisle self-assigned this Oct 13, 2022
@laurencedelisle laurencedelisle added the documentation Improvements or additions to documentation label Oct 13, 2022
@laurencedelisle
Copy link
Contributor Author

laurencedelisle commented Oct 13, 2022

Please double check that the links are correct!

@gesquinca gesquinca self-requested a review October 13, 2022 17:24
Base automatically changed from docs-develop to docs-main October 13, 2022 17:37
@gesquinca gesquinca changed the base branch from docs-main to docs-develop October 13, 2022 17:44
@Adamj1232 Adamj1232 self-requested a review October 19, 2022 21:41
@Adamj1232 Adamj1232 merged commit c9e095c into docs-develop Oct 25, 2022
@Adamj1232 Adamj1232 deleted the update-migration-guide-for-w3o branch October 25, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gesquinca gesquinca Awaiting requested review from gesquinca

1 more reviewer

@Adamj1232 Adamj1232 Adamj1232 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@laurencedelisle laurencedelisle

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@laurencedelisle @gesquinca @Adamj1232