Enhancement: Hardware Wallet Filtering #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamj1232
approved these changes
Sep 1, 2022
Contributor
Adamj1232
left a comment
Adamj1232
left a comment
There was a problem hiding this comment.
Nice, I like that is scoped per wallet module!
This was referenced Sep 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
filterinitialization parameter for all hardware wallet modules which allows for selecting which platforms you would not like the hardware wallet be displayed to the user as a selectable option. This is useful as currently our account select UI for hardware wallets is not mobile optimized (most hardware wallets are not available on mobile devices). We plan on updating this UI in the near future, but in the meantime apps can filter HW out on mobile devices.Closes #1231
Checklist
package.jsonis incremented following semantic versioningyarn type-check&yarn buildto confirm there are not any associated errors