Skip to content

Conversation

@lnbc1QWFyb24
Copy link
Contributor

Description

This PR fixes a typo that was causing the replacement UI to not display on notifications when initiated on a KeepKey wallet. Also added to the list of wallets that support replacement tx's is D'Cent wallet.

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@lnbc1QWFyb24 lnbc1QWFyb24 merged commit 5efc1cc into v2-web3-onboard-develop Sep 2, 2022
@lnbc1QWFyb24 lnbc1QWFyb24 deleted the fix/keepkey-replacement branch September 2, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants