Fix: Add extension to relative imports #1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamj1232
approved these changes
Aug 22, 2022
Contributor
Adamj1232
left a comment
Adamj1232
left a comment
There was a problem hiding this comment.
Dang that's a lot of changes, thanks for doing that!
|
Damn, this is wild! Thanks a lot for this one @aaronbarnardsound ! |
This was referenced Aug 24, 2022
Merged
3 tasks
tomquirk
pushed a commit
to jbx-protocol/juice-interface
that referenced
this pull request
Aug 30, 2022
## What does this PR do and why? Updates to the latest web3-onboard now that the es module bug is fixed (thirdweb-dev/web3-onboard#1227). Closes #1784 ## Screenshots or screen recordings _If applicable, provide screenshots or screen recordings to demonstrate the changes._ ## Acceptance checklist - [ ] I have evaluated the [Approval Guidelines](https://github.com/jbx-protocol/juice-interface/blob/main/CONTRIBUTING.md#approval-guidelines) for this PR. - [ ] I have tested this PR in [all supported browsers](https://github.com/jbx-protocol/juice-interface/blob/main/CONTRIBUTING.md#supported-browsers). - [ ] I have tested this PR in dark mode and light mode (if applicable).
tomquirk
pushed a commit
to jbx-protocol/juice-interface
that referenced
this pull request
Feb 11, 2023
## What does this PR do and why? Updates to the latest web3-onboard now that the es module bug is fixed (thirdweb-dev/web3-onboard#1227). Closes #1784 ## Screenshots or screen recordings _If applicable, provide screenshots or screen recordings to demonstrate the changes._ ## Acceptance checklist - [ ] I have evaluated the [Approval Guidelines](https://github.com/jbx-protocol/juice-interface/blob/main/CONTRIBUTING.md#approval-guidelines) for this PR. - [ ] I have tested this PR in [all supported browsers](https://github.com/jbx-protocol/juice-interface/blob/main/CONTRIBUTING.md#supported-browsers). - [ ] I have tested this PR in dark mode and light mode (if applicable).
tomquirk
pushed a commit
to jbx-protocol/juice-interface
that referenced
this pull request
Feb 11, 2023
## What does this PR do and why? Updates to the latest web3-onboard now that the es module bug is fixed (thirdweb-dev/web3-onboard#1227). Closes #1784 ## Screenshots or screen recordings _If applicable, provide screenshots or screen recordings to demonstrate the changes._ ## Acceptance checklist - [ ] I have evaluated the [Approval Guidelines](https://github.com/jbx-protocol/juice-interface/blob/main/CONTRIBUTING.md#approval-guidelines) for this PR. - [ ] I have tested this PR in [all supported browsers](https://github.com/jbx-protocol/juice-interface/blob/main/CONTRIBUTING.md#supported-browsers). - [ ] I have tested this PR in dark mode and light mode (if applicable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ES modules need to have the file extension included for relative imports to work natively in the browser. TypeScript does not add the file extensions at compile time, but will recognize a
.jsimport as referring to the compiled JavaScript. This PR adds a.jsextension to all relative imports in the codebase.This will fix issues in Vite projects and others that stick to the ES module spec.
Fixes #1226
Checklist
package.jsonis incremented following semantic versioningyarn type-check&yarn buildto confirm there are not any associated errors